Re: SSL encryption patch.

Benno Rice wrote:

> I don't think there are any gotchas in writing code that uses SSL, just in
> actually using the SSL stuff itself. Since we don't have OpenSSL in the
> squid source tree, we should be fine.

SourceForge has given us clearance on having the SSL hooks there, and a
branch has now been created there for you until it is decided that the
hooks can be included in the mainstream distribution.

The patch you sent is applied with some minor transformations
(acconfig.h is the source file, not include/autoconf.h.in), but one
chunk failed:

***************
*** 2525,2531 ****
                if (conn->in.offset >= Config.maxRequestHeaderSize) {
                    int fd = open("/tmp/error:request-too-large",
O_WRONLY | O_CREAT | O_TRUNC);
                    if (fd >= 0) {
- write(fd, conn->in.buf, conn->in.offset);
                        close(fd);
                    }
                    /* The request is too large to handle */
--- 2525,2531 ----
                if (conn->in.offset >= Config.maxRequestHeaderSize) {
                    int fd = open("/tmp/error:request-too-large",
O_WRONLY | O_CREAT | O_TRUNC);
                    if (fd >= 0) {
+ FD_WRITE_METHOD(fd, conn->in.buf,
conn->in.offset);
                        close(fd);
                    }
                    /* The request is too large to handle */

The current Squid code does not look anywhere close to this, so I am not
sure what to do with it.

If you'd like to commit fixes/updates to this CVS repository then please
create yourself a SourceForge account, and ask me or Adrian Chadd to add
you to the project.

/Henrik
Received on Wed Apr 19 2000 - 14:33:40 MDT