Re: cbdata_unlock in fs/*/*io*.c

On Sat, Apr 22, 2000, Henrik Nordstrom wrote:
> Adrian Chadd wrote:
>
> > There are two distinct callbacks there, the read callback and the
> > sio callback. storeUfsIOCallback() is called when the storeIO operation
> > is about to finish.
>
> My primary issue was not about the placement of the callbacks, but how
> cbdata is used in that code. There is no real point in using
> cbdataLock/Unlock unless you also make use of cbdataValid to check the
> validity of the data.
>

Yup. Which is why I've now tidied it up. Is that better?

Adrian
Received on Sat Apr 22 2000 - 09:08:40 MDT