Re: auth_rewrite authenticate.c user_auth_hash_pointer usage

From: Robert Collins <robert.collins@dont-contact.us>
Date: Sun, 14 Jan 2001 09:32:19 +1100

Two reasons:
Aliases
Header caching.

The second reason is now obsolete, but the first isn't.

Rob

----- Original Message -----
From: "Henrik Nordstrom" <hno@hem.passagen.se>
To: <squid-dev@squid-cache.org>
Sent: Sunday, January 14, 2001 8:22 AM
Subject: auth_rewrite authenticate.c user_auth_hash_pointer usage

> Why, in authenticate.c, is a hash built using indirect user_auth_pointer
> structures instead of building a hash of user_auth structures? As far as
> I can see the extra index of the dlink list in the
> user_auth_hash_pointer is not used there.
>
> To make the code more understandable, I suggest removing
> user_auth_hash_pointer usage from there, and instead add a hash node to
> the user_auth structure and hash directly on that. (this also saves some
> small amount of memory per cached user).
>
> /Henrik
>
>
Received on Sat Jan 13 2001 - 15:20:41 MST

This archive was generated by hypermail pre-2.1.9 : Tue Dec 09 2003 - 16:13:18 MST