test suite breakage.

I fixed the http range requests last weekend, this weekend I see:

/home/robertc/source/squid/squid--HEAD--3.0/src/tests/testStoreController.cc: In member function ‘void testStoreController::testStats()’:
/home/robertc/source/squid/squid--HEAD--3.0/src/tests/testStoreController.cc:29: error: cannot allocate an object of abstract type ‘TestSwapDir’
/home/robertc/source/squid/squid--HEAD--3.0/src/tests/TestSwapDir.h:8:
note: because the following virtual functions are pure within
‘TestSwapDir’:
/home/robertc/source/squid/squid--HEAD--3.0/src/SwapDir.h:191: note:
virtual RefCount<StoreIOState> SwapDir::createStoreIO(StoreEntry&, void
(*)(void*, int, RefCount<StoreIOState>), void (*)(void*, int, RefCoun
t<StoreIOState>), void*)
/home/robertc/source/squid/squid--HEAD--3.0/src/SwapDir.h:192: note:
virtual RefCount<StoreIOState> SwapDir::openStoreIO(StoreEntry&, void
(*)(void*, int, RefCount<StoreIOState>), void (*)(void*, int,
RefCount<StoreIOState>), void*)
/home/robertc/source/squid/squid--HEAD--3.0/src/tests/testStoreController.cc:30: error: cannot allocate an object of abstract type ‘TestSwapDir’
/home/robertc/source/squid/squid--HEAD--3.0/src/tests/TestSwapDir.h:8:
note: since type ‘TestSwapDir’ has pure virtual functions
/home/robertc/source/squid/squid--HEAD--3.0/src/tests/testStoreController.cc: In member function ‘void testStoreController::testMaxSize()’:
/home/robertc/source/squid/squid--HEAD--3.0/src/tests/testStoreController.cc:71: error: cannot allocate an object of abstract type ‘TestSwapDir’
/home/robertc/source/squid/squid--HEAD--3.0/src/tests/TestSwapDir.h:8:
note: since type ‘TestSwapDir’ has pure virtual functions
/home/robertc/source/squid/squid--HEAD--3.0/src/tests/testStoreController.cc:72: error: cannot allocate an object of abstract type ‘TestSwapDir’
/home/robertc/source/squid/squid--HEAD--3.0/src/tests/TestSwapDir.h:8:
note: since type ‘TestSwapDir’ has pure virtual functions
/home/robertc/source/squid/squid--HEAD--3.0/src/tests/testStoreController.cc: In member function ‘void testStoreController::testSearch()’:
/home/robertc/source/squid/squid--HEAD--3.0/src/tests/testStoreController.cc:134: error: cannot allocate an object of abstract type ‘TestSwapDir’
/home/robertc/source/squid/squid--HEAD--3.0/src/tests/TestSwapDir.h:8:
note: since type ‘TestSwapDir’ has pure virtual functions
/home/robertc/source/squid/squid--HEAD--3.0/src/tests/testStoreController.cc:135: error: cannot allocate an object of abstract type ‘TestSwapDir’
/home/robertc/source/squid/squid--HEAD--3.0/src/tests/TestSwapDir.h:8:
note: since type ‘TestSwapDir’ has pure virtual functions
make[4]: *** [tests/testStoreController.o] Error 1

Can I beg that people run 'make check' before committing ?

Thanks,
Rob

-- 
GPG key available at: <http://www.robertcollins.net/keys.txt>.