Re: Fwdstats serverfd (Patch)

From: Henrik Nordstrom <henrik@dont-contact.us>
Date: Mon, 26 Jun 2006 16:28:40 +0200

mån 2006-06-26 klockan 11:40 +0800 skrev Steven Wilton:
> When I did the original serverfd work for backed off connections, I assumed
> serverfd=0 was invalid. This patch fixes the code so serverfd=-1 is the
> default when there is no backed-off server fd.

Thanks. Applied.

> I've also added an assert into fd_close to catch any cases where a fd is
> closed while it is backed off. This condition can cause crashes later on
> (Bug #1616 is an example) if not detected.

Not applied as I don't think it will trap 1616 at all as that bug is a
fd being closed while it's still registered as the serverfd of a
deferred StoreEntry, not that the fd as such is deferred. The other
situations the assert maybe could trap is all harmless.

Regards
Henrik

Received on Mon Jun 26 2006 - 08:28:44 MDT

This archive was generated by hypermail pre-2.1.9 : Fri Jun 30 2006 - 12:00:02 MDT