Re: [adrian@squid-cache.org: cvs commit: squid/src client_side.c client_side_rewrite.c client_side_storeurl_rewrite.c protos.h]

From: Pawel Worach <pawel.worach@dont-contact.us>
Date: Sun, 06 Jan 2008 18:37:43 +0100

There seems to be another tiny leak related to vary accept-encoding
processing:

==69932== 56 bytes in 4 blocks are definitely lost in loss record 2 of 23
==69932== at 0x1C835: malloc (vg_replace_malloc.c:149)
==69932== by 0x80CC14B: xmalloc (util.c:437)
==69932== by 0x80CC275: xstrdup (util.c:605)
==69932== by 0x8089088: httpProcessReplyHeader (http.c:544)
==69932== by 0x8089C25: httpReadReply (http.c:944)
==69932== by 0x806F840: comm_select (comm_generic.c:264)
==69932== by 0x8099DDF: main (main.c:859)

Regards
Pawel

Adrian Chadd wrote:
> Oops, my fault here. Thanks to Pawel Worach for bringing the memleak to my attention
> and providing a valgrind trace to help me narrow down what was going on.
>
> I've fixed this in 2.7 and 2.HEAD.
>
>
> Adrian
>
> ----- Forwarded message from Adrian Chadd <adrian@squid-cache.org> -----
>
> Reply-To: Squid Developers <squid-dev@squid-cache.org>
> Date: Sat, 5 Jan 2008 00:33:18 -0700 (MST)
> From: Adrian Chadd <adrian@squid-cache.org>
> To: squid-cvs@squid-cache.org
> Subject: cvs commit: squid/src client_side.c client_side_rewrite.c
> client_side_storeurl_rewrite.c protos.h
>
> adrian 2008/01/05 00:33:18 MST
>
> Modified files: (Branch: SQUID_2_7)
> src client_side.c client_side_rewrite.c
> client_side_storeurl_rewrite.c protos.h
> Log:
> MFC: Fix HttpHdrCc leak - don't call clientInterpretRequestHeaders() twice. Tidy up the code slightly whilst we're at it.
>
> Revision Changes Path
> 1.754.2.2 +19 -1 squid/src/client_side.c
> 1.2.2.1 +1 -4 squid/src/client_side_rewrite.c
> 1.3.2.1 +3 -7 squid/src/client_side_storeurl_rewrite.c
> 1.547.2.2 +3 -1 squid/src/protos.h
>
> ----- End forwarded message -----
>

-- 
Pawel
Received on Sun Jan 06 2008 - 10:37:53 MST

This archive was generated by hypermail pre-2.1.9 : Wed Jan 30 2008 - 12:00:09 MST