Re: Fix squid build with glibc 2.17

On 18/11/2012 12:47 a.m., Andreas Jaeger wrote:
> Building squid failed with a git snapshot of glibc 2.17 on openSUSE
> with the following:
>
> pinger.cc: In function 'int main(int, char**)':
> pinger.cc:183:21: error: ignoring return value of 'int setgid(__gid_t)', declared with attribute warn_unused_result [-Werror=unused-result]
> pinger.cc:184:21: error: ignoring return value of 'int setuid(__uid_t)', declared with attribute warn_unused_result [-Werror=unused-result]
> cc1plus: all warnings being treated as errors
>
> And similar with tools.cc.
>
> I've fixed this with the patch below and suggest to apply it,
> Andreas

Thank you Andreas. I have applied with a few tweaks:
  * use of named DBG_CRITICAL / DBG_IMPORTANT level macros instead of 0/1.
  * use of xstrerror() and getgid() in error message for better
administrator help.

Amos
Received on Sun Nov 18 2012 - 05:25:19 MST